fix(vite): provide correct root directory when building a root project #19298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue where our Vite executors are passing
''
as the root directory to Vite, which results in it not findingpackage.json
to detecttype: 'module'
. This means that root apps which use ESM-only packages will fail to build.You can see the issue here: https://github.com/jaysoo/nx-vite-root-issue
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #