Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): remove deprecated babel transform #19671

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Oct 17, 2023

@babel/plugin-proposal-class-properties is deprecated and the new transform is already in @babel/preset-env so it is not necessary. This PR removes it and deprecates the classProperties.loose option in @nx/js/babel preset in favour of the broader loose option.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested review from a team as code owners October 17, 2023 20:30
@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 0:35am

@jaysoo jaysoo force-pushed the fix/remove-unused-babel-plugin branch from 183b87a to 10ac833 Compare October 17, 2023 20:58
@jaysoo jaysoo force-pushed the fix/remove-unused-babel-plugin branch from 10ac833 to a66f36f Compare October 18, 2023 12:35
@jaysoo jaysoo merged commit 472dbc3 into nrwl:master Oct 18, 2023
6 checks passed
@jaysoo jaysoo deleted the fix/remove-unused-babel-plugin branch October 18, 2023 14:44
@Michsior14
Copy link
Contributor

Aren't class-properties available on es2022 only? So all executors that uses older versions (e.g. rollup supports: es2015, es2020 and esnext) won't work anymore?

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants