Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): fix regression with --thirdParty option for esbuild #19835

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Oct 24, 2023

Current Behavior

Passing thirdParty: false is not working, and bundling npm packages into bundle.

Expected Behavior

Passing thirdParty: false should work.

Related Issue(s)

Fixes #19773

@jaysoo jaysoo requested a review from a team as a code owner October 24, 2023 20:15
@jaysoo jaysoo requested a review from mandarini October 24, 2023 20:15
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 1:06am

@jaysoo jaysoo self-assigned this Oct 24, 2023
@jaysoo jaysoo changed the title fix(esbuild): fix regression with --thirdParty option for esbuild fix(bundling): fix regression with --thirdParty option for esbuild Oct 24, 2023
@jaysoo jaysoo merged commit 75062ef into nrwl:master Oct 25, 2023
6 checks passed
@jaysoo jaysoo deleted the issue/19773 branch October 25, 2023 12:18
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants