Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure Github repo slug can be resolved in nx release changelog #20001

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

guysenpai
Copy link
Contributor

closed #19998

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #19998

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 0:48am

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @guysenpai! You're not only using an undocumented alpha feature but also submitting fixes for it to 💙

Please do be aware thought that there are likely some more breaking config changes coming within the next couple of weeks that will not be automatically migrated.

As soon as we document it and remove that alpha label, all the usual migrations etc will be applied to future versions

@JamesHenry JamesHenry changed the title fix(core): could not determine Github repo slug when run nx release changelog on Github action workflow fix(core): ensure Github repo slug can be resolved in nx release changelog Nov 6, 2023
@JamesHenry JamesHenry enabled auto-merge (squash) November 6, 2023 11:05
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just seen you have removed an ignore file, please revert that and stick with the relevant change

auto-merge was automatically disabled November 6, 2023 12:35

Head branch was pushed to by a user without write access

@JamesHenry
Copy link
Collaborator

@guysenpai you still have more than one file changed

@JamesHenry JamesHenry enabled auto-merge (squash) November 6, 2023 12:48
@JamesHenry JamesHenry merged commit 33ca596 into nrwl:master Nov 6, 2023
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run nx release changelog on Github action workflow could not determine Github repo slug
2 participants