Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): component generator should work without sourceRoot #20094

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Nov 7, 2023

Current Behavior

If a project does not have source root, generator fails.

Expected Behavior

Component generator should use project root is source root is not found.

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner November 7, 2023 14:29
@jaysoo jaysoo requested a review from mandarini November 7, 2023 14:29
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 2:29pm

@jaysoo jaysoo merged commit 8a9f43f into nrwl:master Nov 7, 2023
6 checks passed
@jaysoo jaysoo deleted the fix/NXP-339 branch November 7, 2023 19:20
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants