Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): support adding plugin at a later stage #20557

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Dec 4, 2023

Current Behavior

Eslint Init generator can add plugin instead of target defaults only on a fresh workspace, where eslint hasn't been initialized yet. Calling one of the eslint generators at the later point with NX_PCV3 flag yields not result, since we bale out immediately upon finding root config.

Expected Behavior

If plugin was not set up in nx.json it should be added at any point by calling generators with NX_PCV3 flag

Related Issue(s)

Fixes #

@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Dec 4, 2023
@meeroslav meeroslav self-assigned this Dec 4, 2023
@meeroslav meeroslav requested a review from a team as a code owner December 4, 2023 12:40
Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 3:58pm

@meeroslav meeroslav merged commit 804959a into nrwl:master Dec 5, 2023
6 checks passed
@meeroslav meeroslav deleted the fix-eslint-add-plugin-later branch December 5, 2023 15:33
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants