Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module-federation): allow relative remote paths #20763

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Dec 14, 2023

Current Behavior

Relative remote paths stopped working as a result of us adding support for promise based remotes

Expected Behavior

Allow relative remote paths to continue to work

Related Issue(s)

Fixes #20545

@Coly010 Coly010 self-assigned this Dec 14, 2023
Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 11:12am

Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Coly010 Coly010 marked this pull request as ready for review December 14, 2023 16:51
@Coly010 Coly010 requested a review from jaysoo as a code owner December 14, 2023 16:51
@Coly010 Coly010 merged commit 439a31c into nrwl:master Dec 14, 2023
6 checks passed
@Coly010 Coly010 deleted the mf/fix-relative-remotes branch December 15, 2023 09:32
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular monorepo with module federation, relative remotes are not loaded
3 participants