Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(angular): generate public directory instead of assets #22801

Merged
merged 3 commits into from
Apr 15, 2024
Merged

feat(angular): generate public directory instead of assets #22801

merged 3 commits into from
Apr 15, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Apr 12, 2024 •
edited
Loading

Upstream change: angular/angular-cli@6530aa1

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Apr 12, 2024
@leosvelperez leosvelperez requested review from a team as code owners April 12, 2024 10:13
@leosvelperez leosvelperez requested review from FrozenPandaz and isaacplmann and removed request for a team April 12, 2024 10:13
@vercel Vercel
Copy link

vercel bot commented Apr 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 8:34am

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 12, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3b05043. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx affected --targets=e2e,e2e-ci --base=a627ce84b1420b20e6d48fd7f98a5e08b1a13a86 --head=3b05043cd30fb6e6f4fda82474b7b5c0bded1032 --parallel=1
✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@leosvelperez leosvelperez requested review from Coly010 and removed request for a team, FrozenPandaz and isaacplmann April 12, 2024 10:14
Coly010
Coly010 requested changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the host generator (might be setup-mf) when dynamic is true to generate the module federation manifest in public directory, as well as update the bootstrap template to fetch from the correct directory

Coly010
Coly010 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leosvelperez leosvelperez merged commit 3f51439 into nrwl:angular/v18 Apr 15, 2024
4 of 6 checks passed
@leosvelperez leosvelperez deleted the angular/v18-public-dir branch April 15, 2024 09:15
leosvelperez added a commit that referenced this pull request Apr 19, 2024
@leosvelperez
feat(angular): generate public directory instead of assets (#22801)
beaeb17
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Coly010 Coly010 Coly010 approved these changes

Assignees

@leosvelperez leosvelperez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leosvelperez @Coly010