TypeScript module resolution and lint updates #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cammisuli
force-pushed
the
target-project-locator-fixes
branch
from
6c6c4b3
to
191f7ec
Compare
|
Tested the changes with ocean and nx-examples. We will need to update ocean to remove circular dependencies. Nx-examples ran fine. If there's another nx repo that's fairly mature, I can test it there as well. |
Cammisuli
force-pushed
the
target-project-locator-fixes
branch
3 times, most recently
from
6176261
to
4cdcfb0
Compare
Cammisuli
changed the title
Cammisuli
force-pushed
the
target-project-locator-fixes
branch
3 times, most recently
from
5ff8801
to
ab14b43
Compare
This reverts commit 0b77072.
This will sort nodes by length of the root (high to low) then nodes that have no root. It also uses TypeScript to first try and resolve a module. If it is not found via TypeScript, it will fall back to using a string match.
Cammisuli
force-pushed
the
target-project-locator-fixes
branch
from
ab14b43
to
ff3c6c9
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure you have read the submission guidelines before posting an PR
Current Behavior (This is the behavior we have today, before the PR is merged)
Imports are found via string comparison.
Expected Behavior (This is the new behavior we can expect after the PR is merged)
Imports are found via TypeScript then fallback to the previous implementation. Project nodes are also sorted properly sorted by:
This also includes updates to linting, and will find more dependency edges because of TypeScript.
Previously, we could import relatively to a file in an app like so (and telling tslint to ignore imports into libs):
../../../apps/myapp/environment/environment.ts.Doing this will now add that app a dependency to the project using it. This could potentially cause linting errors with circular dependencies.
Issue