Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nx-dev): Add 404 for unknown blog urls #23267

Merged
merged 1 commit into from
May 9, 2024

Conversation

ndcunningham
Copy link
Contributor

This PR adds the 404 fallback if a user navigates to a specified blog that does not exist.

Currently, we are showing a 500 error.

@ndcunningham ndcunningham self-assigned this May 9, 2024
@ndcunningham ndcunningham requested a review from a team as a code owner May 9, 2024 14:20
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 9, 2024 3:18pm

@isaacplmann
Copy link
Collaborator

I don't think it is working:
https://nx-dev-git-fix-nx-docs-blog-404-nrwl.vercel.app/blog/fake

@ndcunningham ndcunningham merged commit bdac1e2 into master May 9, 2024
6 checks passed
@ndcunningham ndcunningham deleted the fix/nx-docs-blog-404 branch May 9, 2024 15:30
FrozenPandaz pushed a commit that referenced this pull request May 13, 2024
This PR adds the 404 fallback if a user navigates to a specified blog
that does not exist.

Currently, we are showing a 500 error.

(cherry picked from commit bdac1e2)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants