feat(nest): implement nest lib schematic

[yharaskrik]

Current Behavior (This is the behavior we have today, before the PR is merged)

Can only generate nest apps

Expected Behavior (This is the new behavior we can expect after the PR is merged)

Can now generate a nest library with optional service, controller and @global module

Closes #1010
Closes #2378

[Cammisuli]

Looks good! I suggest you try to use the @nrwl/node:lib schematic instead of the workspace one. The node one includes a lot of the handling for publishing and creating tsconfig files. You can massage the files the node:lib schematic creates if you need to.

Also, can you please update the shared-new.ts file here to include the nest library:

nx/packages/workspace/src/schematics/shared-new/shared-new.ts

Line 255 in d7be9c1

json.schematics['@nrwl/nest'] = { application: { linter } };

[yharaskrik]

@Cammisuli I made your requested changed and added a couple of other things, defaulting the es target to es6 for nest libraries (as suggested by Kamil) and setting the testEnvironment in the jest.config.js to 'node' rather than jsdom since we are not using nest libs in a DOM environment and if anyone is using mongoose than mongoose suggests using the 'node' env rather than 'jsdom' env.

#1002
https://mongoosejs.com/docs/jest.html

[yharaskrik]

check-imports.js also failed because I am importing from angular devkit (the stripIndents function) but apparently that is not allowed?

[Cammisuli]

Please remember to update

nx/packages/workspace/src/schematics/shared-new/shared-new.ts

Line 255 in d7be9c1

json.schematics['@nrwl/nest'] = { application: { linter } };

Also, I just realized that e2e's are needed for the nest changes (in node.test.ts) and the jest changes.

[yharaskrik]

Thanks for the feedback @Cammisuli I could have sworn I updated that shared-new.ts file but maybe I daydreamed that.

[yharaskrik]

@Cammisuli I am encountering a strange situation with the e2e tests. When I run the e2e tests that I wrote they fail linting with:

Linting "nestlib9652709"...
    
    ERROR: /Users/jaybell/WebstormProjects/nx/tmp/nx/proj/libs/nestlib9652709/src/index.ts[4, 1]: unused expression, expected an assignment or function call
    ERROR: /Users/jaybell/WebstormProjects/nx/tmp/nx/proj/libs/nestlib9652709/src/index.ts[4, 7]: unused expression, expected an assignment or function call
    
     Lint errors found in the listed files.

But this expect passes in the unit tests

const barrel = getFileContent(tree, 'libs/my-lib/src/index.ts');
      expect(stripIndents`${barrel}`).toEqual(
          stripIndents`export * from './lib/my-lib.module';
          export * from './lib/my-lib.service';
          export * from './lib/my-lib.controller';`
      );

I am not sure how both of those cases can be true, if you have some input that would be awesome.

Also, would you like me to split these nest tests out into their own e2e file? Or leave them in with node? As the nest schematics grow it might make the most sense to split them out since @nrwl/nest is a different package than @nrwl/node?

I still need to write the jest e2e tests but everything else should be good now.

[Cammisuli]

Don't worry about splitting the e2e file. I'll do that sometime next week.

[yharaskrik]

Ok sounds good. I would like to add more in the future to nest (generated integration testing, guards, interceptors etc) so don't want that file to get crowded.

[yharaskrik]

@Cammisuli what would be the best way to load the value of the jest.config.js into memory to check the testEnvironment in the e2e test? Is there a util function I can use to load it into a json object?

[Cammisuli]

There should be a function called `readFile` or `readJson` exported from the utils folder in the e2e folder.

…

On Fri, Feb 28, 2020 at 13:39 Jay Bell ***@***.***> wrote: @Cammisuli <https://github.com/Cammisuli> what would be the best way to load the value of the jest.config.js into memory to check the testEnvironment in the e2e test? Is there a util function I can use to load it into a json object? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2540?email_source=notifications&email_token=ABBBXLFQBIWFYYO2U5QM7RTRFFK4VA5CNFSM4K2A3WRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENJWGHA#issuecomment-592667420>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBBXLGI3UNYBEWLXIVGHSLRFFK4VANCNFSM4K2A3WRA> .

[Cammisuli]

LGTM, thanks for the PR!

[yharaskrik]

Thanks! I did implement some of the other main nest features as well in another PR that refractors some of the code in this PR as well as splits service and controller out so they can be generated independently.

[Cammisuli]

We'll keep them separated. Let's get this merged in, run some smoke tests to make sure everything is good, and then get the next one in.

[yharaskrik]

Sounds good! Figured that's how we would do it. The other has quite a bit of changes and I realistically could write more unit tests as there are a lot of different combinations of flags now for a lib

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.