Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expo): fix expo start windows #26493

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Jun 10, 2024

Current Behavior

  • interactive command does not work on windows, use executor instead

Expected Behavior

Related Issue(s)

Fixes #24138

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 11:10pm

@xiongemi xiongemi changed the title Fix/fix expo start windows fix(expo): fix expo start windows Jun 10, 2024
@xiongemi xiongemi marked this pull request as ready for review June 10, 2024 17:10
@xiongemi xiongemi requested a review from a team as a code owner June 10, 2024 17:10
@xiongemi xiongemi requested a review from jaysoo June 10, 2024 17:10
@xiongemi xiongemi mentioned this pull request Jun 14, 2024
4 tasks
@xiongemi xiongemi merged commit fe30d02 into master Jun 19, 2024
6 checks passed
@xiongemi xiongemi deleted the fix/fix-expo-start-windows branch June 19, 2024 01:08
FrozenPandaz pushed a commit that referenced this pull request Jun 21, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
- interactive command does not work on windows, use executor instead

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #24138

(cherry picked from commit fe30d02)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android build failing in Expo App
3 participants