Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add helper function to devkit to add viewProviders to a component #26526

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

Olster
Copy link
Contributor

@Olster Olster commented Jun 12, 2024

Current Behavior

Angular Nx utils have addProviderToComponent function to add a provider to an Angular component, but are missing a function to add viewProviders.

Expected Behavior

There should be a function like addProviderToComponent to add view providers to a component.

@Olster Olster requested a review from a team as a code owner June 12, 2024 13:59
@Olster Olster requested a review from leosvelperez June 12, 2024 13:59
Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 17, 2024 8:18am

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@leosvelperez leosvelperez merged commit 15b7e9f into nrwl:master Jun 17, 2024
6 checks passed
@Olster Olster deleted the view-provider branch June 17, 2024 08:52
FrozenPandaz pushed a commit that referenced this pull request Jun 21, 2024
…a component (#26526)

## Current Behavior

Angular Nx utils have `addProviderToComponent` function to add a
provider to an Angular component, but are missing a function to add
viewProviders.

## Expected Behavior

There should be a function like `addProviderToComponent` to add view
providers to a component.

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
(cherry picked from commit 15b7e9f)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants