fix(graph): improve layout when target groups are empty or there are no groups #26555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysoo
requested review from
philipjfulcher,
FrozenPandaz,
bcabanes,
MaxKless and
xiongemi
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0a33bc4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
xiongemi
approved these changes
Jun 14, 2024
jaysoo
force-pushed
the
fix/pdv-layout-improvements
branch
from
3ebae44
to
0a33bc4
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 21, 2024
…no groups (#26555) This PR fixes empty target groups and adds consistency between grouped and ungrouped targets. ## Before Empty groups have bad empty state -- we should not show it. The ungrouped targets being on their own without a group is also inconsistent. <img width="1153" alt="Screenshot 2024-06-14 at 9 46 11 AM" src="https://github.com/nrwl/nx/assets/53559/b6e96187-fc6f-4c3f-9b45-39744d02b0ec"> ## After If group is empty, don't render it. Also, if there are no groups then don't nest the ungrouped targets. <img width="1190" alt="Screenshot 2024-06-14 at 9 46 29 AM" src="https://github.com/nrwl/nx/assets/53559/76cd0b32-532b-470d-ad2f-85fc3aaf3997"> If there are groups, put the ungrouped targets into `Others`. <img width="1152" alt="Screenshot 2024-06-14 at 9 45 55 AM" src="https://github.com/nrwl/nx/assets/53559/465e64c7-e376-4555-b580-d6ecaafb61f5"> (cherry picked from commit 09a08c6)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes empty target groups and adds consistency between grouped and ungrouped targets.
Before
Empty groups have bad empty state -- we should not show it. The ungrouped targets being on their own without a group is also inconsistent.
After
If group is empty, don't render it. Also, if there are no groups then don't nest the ungrouped targets.
If there are groups, put the ungrouped targets into
Others.