fix(graph): fix search params reload when back to graph #26580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiongemi
requested review from
philipjfulcher,
FrozenPandaz,
bcabanes,
MaxKless and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7c8e839. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
xiongemi
force-pushed
the
feature/nxc-679-showing-the-graph-of-a-targettask-takes-too-long
branch
from
2cceaf6
to
cbee524
Compare
FrozenPandaz
requested changes
Jun 21, 2024
xiongemi
force-pushed
the
feature/nxc-679-showing-the-graph-of-a-targettask-takes-too-long
branch
from
cbee524
to
7c8e839
Compare
jaysoo
approved these changes
Jun 24, 2024
FrozenPandaz
approved these changes
Jun 25, 2024
FrozenPandaz
deleted the
feature/nxc-679-showing-the-graph-of-a-targettask-takes-too-long
branch
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 26, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> - change useIntervalWhen - when this function is used, it is mostly calling a fetch request, change it to take an async function - wait for the current fetch request to finish before firing the next one - change the name to usePoll - currently, when going back to graph, it needs to remove the search params expand and sometimes need to add ?project= search params - delete expand search params is called after adding the project search params ``` setSearchParams( (currentSearchParams) => { currentSearchParams.delete('expanded'); return currentSearchParams; }, { replace: true, preventScrollReset: true } ); ``` this function does not contain the ?project= search param key, caused the graph page to reload twice - change the function useRouteConstructor to delete the search params `expanded` there ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 6ebf676)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
this function does not contain the ?project= search param key, caused the graph page to reload twice
expandedthereExpected Behavior
Related Issue(s)
Fixes #