-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): update pnpm/action-setup to v4 in ci-workflow generator #26838
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fd58bfb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you for providing the fix.
Please update also tests/fixtures to match the template change.
…26838) I just created a new nx monorepo with pnpm and in the github.ci file it uses pnpm/action-setup@v2. I ran into the following issue pnpm/action-setup#136 and updating to pnpm/action-setup@v4 solved the issue for me --------- Co-authored-by: Jan-Niklas Wortmann <jan-niklas.wortmann@jetbrains.com> Co-authored-by: Miroslav Jonaš <missing.manual@gmail.com>
…26838) I just created a new nx monorepo with pnpm and in the github.ci file it uses pnpm/action-setup@v2. I ran into the following issue pnpm/action-setup#136 and updating to pnpm/action-setup@v4 solved the issue for me --------- Co-authored-by: Jan-Niklas Wortmann <jan-niklas.wortmann@jetbrains.com> Co-authored-by: Miroslav Jonaš <missing.manual@gmail.com> (cherry picked from commit 9faeddc)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
I just created a new nx monorepo with pnpm and in the github.ci file it uses pnpm/action-setup@v2.
I ran into the following issue pnpm/action-setup#136 and updating to pnpm/action-setup@v4 solved the issue for me