Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): update pnpm/action-setup to v4 in ci-workflow generator #26838

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

niklas-wortmann
Copy link
Contributor

I just created a new nx monorepo with pnpm and in the github.ci file it uses pnpm/action-setup@v2.
I ran into the following issue pnpm/action-setup#136 and updating to pnpm/action-setup@v4 solved the issue for me

@niklas-wortmann niklas-wortmann requested a review from a team as a code owner July 5, 2024 14:02
Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 24, 2024 11:10am

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for providing the fix.

Please update also tests/fixtures to match the template change.

@meeroslav meeroslav enabled auto-merge (squash) July 23, 2024 11:33
@meeroslav meeroslav merged commit 9faeddc into nrwl:master Jul 24, 2024
6 checks passed
ndcunningham pushed a commit that referenced this pull request Jul 24, 2024
…26838)

I just created a new nx monorepo with pnpm and in the github.ci file it
uses pnpm/action-setup@v2.
I ran into the following issue
pnpm/action-setup#136 and updating to
pnpm/action-setup@v4 solved the issue for me

---------

Co-authored-by: Jan-Niklas Wortmann <jan-niklas.wortmann@jetbrains.com>
Co-authored-by: Miroslav Jonaš <missing.manual@gmail.com>
FrozenPandaz pushed a commit that referenced this pull request Jul 24, 2024
…26838)

I just created a new nx monorepo with pnpm and in the github.ci file it
uses pnpm/action-setup@v2.
I ran into the following issue
pnpm/action-setup#136 and updating to
pnpm/action-setup@v4 solved the issue for me

---------

Co-authored-by: Jan-Niklas Wortmann <jan-niklas.wortmann@jetbrains.com>
Co-authored-by: Miroslav Jonaš <missing.manual@gmail.com>
(cherry picked from commit 9faeddc)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants