Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): only stop daemon if enabled #28146

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Sep 26, 2024

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #27971

@xiongemi xiongemi requested a review from a team as a code owner September 26, 2024 18:12
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 2:30pm

@xiongemi xiongemi changed the title fix(core): add try catch around watcher fix(core): dynamically import daemon in reset Sep 26, 2024
@xiongemi xiongemi changed the title fix(core): dynamically import daemon in reset fix(core): dynamically import daemonClient in reset Sep 26, 2024
packages/nx/src/command-line/reset/reset.ts Outdated Show resolved Hide resolved
packages/nx/src/command-line/reset/reset.ts Outdated Show resolved Hide resolved
packages/nx/src/command-line/reset/reset.ts Outdated Show resolved Hide resolved
@xiongemi xiongemi changed the title fix(core): dynamically import daemonClient in reset fix(core): only stop daemon if enabled Sep 27, 2024
@xiongemi xiongemi merged commit 0061b85 into master Sep 27, 2024
6 checks passed
@xiongemi xiongemi deleted the fix/add-try-catch-watcher branch September 27, 2024 16:09
@dunika
Copy link

dunika commented Sep 27, 2024

Thanks!

FrozenPandaz pushed a commit that referenced this pull request Sep 27, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #27971

(cherry picked from commit 0061b85)
Copy link

github-actions bot commented Oct 3, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx reset hangs on CI
3 participants