Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): remove deprecated jest builder options from schematic #3630

Merged
merged 1 commit into from
Sep 5, 2020

Conversation

ZachJW34
Copy link
Contributor

Current Behavior

Jest schematic adds deprecated options to project config in workspace.json

Expected Behavior

Jest schematic does NOT add deprecated options to project config in workspace.json

Related Issue(s)

Fixes #3505

@ZachJW34 ZachJW34 force-pushed the remove-deprecated-jest-options branch from 0fa986f to e620ea8 Compare August 31, 2020 00:11
@Cammisuli Cammisuli self-assigned this Aug 31, 2020
Copy link
Member

@Cammisuli Cammisuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for the PR! 😄

@Cammisuli Cammisuli merged commit 556385c into nrwl:master Sep 5, 2020
Doginal pushed a commit to Doginal/nx that referenced this pull request Nov 25, 2020
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest Schematic still adds setupFile & tsConfig
2 participants