-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): add react fast refresh to webpack #5612
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/2Y46jFaqnTu95vKEDrvZ8SwGsnuB |
Nx Cloud ReportCI ran the following commands for commit 4d91a38. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
f3b1fc9
to
c07407f
Compare
c07407f
to
65db64f
Compare
65db64f
to
dfdf29a
Compare
@@ -26,6 +26,14 @@ Type: `string` | |||
|
|||
Target which builds the application | |||
|
|||
### hmr | |||
|
|||
Default: `false` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we enable by default so users will get the better experience out of the box?
And they can use --no-hmr
or --hmr false
to disable it.
dfdf29a
to
db02cd0
Compare
db02cd0
to
28558c5
Compare
28558c5
to
4d91a38
Compare
nice to see this released |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
add fast refresh to react
Current Behavior
change files will cause a full page to reload
Expected Behavior
change files should only update components on the page
nx serve <app>
will enable fast refresh; for other app like angular, runnx serve <app> --hmr
will enable fast refreshRelated Issue(s)
Fixes #