-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storybook): from addon knobs to controls #6068
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/DKKv6aorbFF9P62hrxCmLETwW94v |
Nx Cloud ReportCI ran the following commands for commit 7c993ae. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff!!! Can't wait to see controls included in the upcoming versions 😎
I added a few comments, feel free to ignore or reach out about them!
packages/angular/src/generators/component-story/files/__componentFileName__.stories.ts__tmpl__
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/component-story/files/__componentFileName__.stories.ts__tmpl__
Outdated
Show resolved
Hide resolved
packages/react/src/generators/component-story/files/__componentFileName__.stories.__fileExt__
Outdated
Show resolved
Hide resolved
packages/react/src/generators/component-story/files/__componentFileName__.stories.__fileExt__
Outdated
Show resolved
Hide resolved
packages/storybook/src/generators/configuration/root-files/.storybook/main.js
Outdated
Show resolved
Hide resolved
187343b
to
9446ba1
Compare
2618eab
to
1ab9dad
Compare
1ab9dad
to
8bcbe67
Compare
Updated todo list:
|
8ba1172
to
50389e5
Compare
50389e5
to
d4d0c8f
Compare
71aa240
to
af06b99
Compare
af06b99
to
1396d24
Compare
0d6eabc
to
7f4e337
Compare
7f4e337
to
ee47bff
Compare
ee47bff
to
ed0b905
Compare
ed0b905
to
e6e8bf4
Compare
e6e8bf4
to
309e5e3
Compare
309e5e3
to
3bc3f37
Compare
3bc3f37
to
b51ab4a
Compare
b51ab4a
to
c7adba2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c7adba2
to
d9eb4d8
Compare
d9eb4d8
to
7c68515
Compare
7c68515
to
7c993ae
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Our Storybook package now uses
@storybook/addon-knobs
. This will be deprecated in Storybook v7. The time has come to move to@storybook/addon-controls
note: please be patient, still working on itWhat this includes
For new Nx workspaces
storybook-configuration
) will install the@storybook/addon-essentials
package, part of which is@storybook/addon-controls
, and it includes some more "essential" Storybook features (eg.docs
). You can disable features you do not need anytime in yourmain.js
.For existing Nx workspaces
nx migrate
to the latest version, yourpackage.json
will be updated to include the@storybook/addon-essentials
package. The@storybook/addon-essentials
addon will be added in youraddons
array in your rootmain.js
file. You will need to runnpm/yarn install
to have it installed.@nrwl/storybook
,@nrwl/workspace
and@nrwl/angular
or@nrwl/react
, you will need to manually doyarn add -D @storybook/addon-essentials
. You will also need to add the addon manually in youraddons
array in your rootmain.js
file.