Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nextjs): use custom build path rather than output path #6069

Merged
merged 1 commit into from
Jun 18, 2021
Merged

docs(nextjs): use custom build path rather than output path #6069

merged 1 commit into from
Jun 18, 2021

Conversation

kirjai
Copy link
Contributor

@kirjai kirjai commented Jun 18, 2021

Current Behavior

This contains two fixes:

  • Currently, the two Vercel deployment images are broken:

Screenshot 2021-06-18 at 17 56 34

Expected Behavior

  • the docs should not encourage using --outputPath=.
    • changed the docs and screenshots to reflect that a custom build output path should be used instead
    • done so only for the "latest" version of the docs though
  • images should work
    • so what i've done is moved those images from a github link to the repo (i did optimize them manually with tinypng).

Related Issue(s)

Fixes #5982, #5748, #5660

@vercel
Copy link

vercel bot commented Jun 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/A5hN686Qseu9ocZu4WGDYUUxrMpm
✅ Preview: https://nx-dev-git-fork-kirjai-next-docs-dist-path-nrwl.vercel.app

@@ -1,5 +1,4 @@
import {
NxJsonConfiguration,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having this unused import here has been throwing an error on CI. not entirely sure why this isn't an issue on master even though this branch is rebased and up to date at the time of writing.

@nx-cloud
Copy link

nx-cloud bot commented Jun 18, 2021

Nx Cloud Report

CI ran the following commands for commit 49842a2. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --parallel --max-parallel=3
#000000 nx affected --target=e2e
#000000 nx affected --target=lint --parallel --max-parallel=4
#000000 nx affected --target=test --parallel --max-parallel=2
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

@bcabanes bcabanes merged commit 0f4c182 into nrwl:master Jun 18, 2021
@kirjai kirjai deleted the next-docs-dist-path branch June 18, 2021 18:50
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants