Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(angular): support angular 13 #7161

Merged
merged 18 commits into from
Nov 8, 2021

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Sep 28, 2021

Support Angular 13

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@Coly010 Coly010 self-assigned this Sep 28, 2021
@vercel
Copy link

vercel bot commented Sep 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/3SjPKttvNNnuVtLBoMTDfzHADj8g
✅ Preview: https://nx-dev-git-fork-coly010-angular-next-release-nrwl.vercel.app

@Coly010
Copy link
Contributor Author

Coly010 commented Oct 8, 2021

@JamesHenry
Copy link
Collaborator

FYI angular-eslint is currently blocked from supporting v13, have raised it with the Angular Team and hoping to hear back today.

Tracking issue: angular-eslint/angular-eslint#715

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

There are still a few known issues as of this PR but this is good enough to start testing.

Known Issues

  • major: Storybook does not support angular 13 yet
  • major: Some beta versions (which may still have issues being ironed out) are being used:
    • @ngrx
    • jest-preset-angular
  • minor: There's an issue with pnpm + rxjs + @nrwl/angular testing utils where the wrong rxjs version gets picked up for typing.

@FrozenPandaz FrozenPandaz merged commit 8d6ac4f into nrwl:master Nov 8, 2021
@samartomar
Copy link

using "@nrwl/angular": "13.1.3" , but the building library still fails we are in the middle of the deployment cycle any help is appriciated.

@wSedlacek
Copy link
Contributor

@samartomar From what I can tell the changes in this PR are not released in 13.1.3 as that release was cut 8 days ago and this was merged 3 days ago.

The 13.2.0-beta releases look like they would include this change though.

I am quite excited for 13.2.0 myself, looks like it is going to be a killer release with NestJS 8 and Angular 13 support in the same release.

@Coly010
Copy link
Contributor Author

Coly010 commented Nov 11, 2021

@samartomar If you're having an issue with buildable libraries, could you open a GH Issue for it? @wSedlacek is correct, there is partial support in nx 13.2.0-beta.1, however, it contains some issues that we're working on currently. It also doesn't contain Storybook support. That is also currently being worked on.

@samartomar
Copy link

@wSedlacek @Coly010 Thank you, Yes i am using NX 13.1.3 with Angular 13, for libs i had default to angular builder, Nx builder for libs is failed, but apart from that i am still able to continue using NX. @Coly010 I will open github issue thank you.

@leosvelperez
Copy link
Member

@samartomar please note Angular 13 is not supported in Nx v13.1.3, therefore issues are expected to happen.

As others have mentioned in this thread we are currently working towards releasing 13.2.0 which will have support for Angular 13. Unfortunately, Angular 13 has important breaking changes for tool authors and it has caused several tools to break (most of them have been solved, though we are still working with the Storybook team to support Angular 13) and it's the reason why adding support for it in Nx have been delayed more than what we would have liked.

Please keep an eye on the releases to know when Angular 13 is supported.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants