-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storybook): handle defaultProject issues with projectBuildConfig flag #8494
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/xjXoYFwitfueULUWjEDLH4JRmP6X [Deployment for d7ef23a canceled] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(let's discuss the changes :) )
0eb0e7d
to
2cb8ded
Compare
2cb8ded
to
7a28a00
Compare
7a28a00
to
ce95d3c
Compare
ce95d3c
to
8a641d0
Compare
8a641d0
to
ebd8cd3
Compare
ebd8cd3
to
d8fdbd5
Compare
d8fdbd5
to
0719ac5
Compare
4ea1859
to
6281963
Compare
6281963
to
76fedd1
Compare
76fedd1
to
252594b
Compare
252594b
to
de3e5ac
Compare
de3e5ac
to
0077976
Compare
0077976
to
8505638
Compare
8505638
to
6282466
Compare
6282466
to
1be30f5
Compare
1be30f5
to
5b8c47e
Compare
…flag * fix(storybook): better error logging for missing projectBuildConfig * feat(storybook): migrator to add projectBuildConfig * fix(storybook): set projectBuildConfig in storybook configuration generator * fix(storybook): find the correct targets for build and storybook
5b8c47e
to
d7ef23a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Storybook uses the build config of the default project as specified in
nx.json
and it can lead to issues. Also, if there is no default project specified, Storybook breaks.Expected Behavior
projectBuildConfig
is not specified - explain what the user should doprojectBuildConfig
in the project's Storybook configurationprojectBuildConfig
option under thestorybook
andbuild-storybook
targets in new project configurationsRelated Issue(s)
Potentially linked to the Storybook+Angular 13 issues. Will of course check back if bugs persist.
I know some of these are older than Angular 13, but most of these seem related to the defaultProject issue.
#8199
#8527
storybookjs/storybook#16977
#7897
#7159
#8527
#8373
#8360
#8255
#8115
#8561
Fixes #