DO NOT MERGE - feat(angular): use withModuleFederation for mfe #9454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit b692083. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/BiCPRbviE2WCNXN1ywecyugYKJcQ [Deployment for b692083 canceled] |
Coly010
force-pushed
the
angular/switch-mfe
branch
from
9ad8fb0
to
c94dd55
Compare
leosvelperez
requested changes
Mar 23, 2022
packages/angular/src/generators/setup-mfe/files/webpack/webpack.config.js__tmpl__
Outdated
Show resolved
Hide resolved
packages/angular/src/generators/setup-mfe/lib/add-remote-to-host.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
angular/switch-mfe
branch
from
c94dd55
to
b692083
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
our mfe generators currently use the old verbose method of creating a module federation config
Expected Behavior
our mfe generators should use the new
withModuleFederation💪