Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE - docs(angular): update the mfe guide #9478

Merged
merged 1 commit into from
Mar 24, 2022
Merged

DO NOT MERGE - docs(angular): update the mfe guide #9478

merged 1 commit into from
Mar 24, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Mar 23, 2022

Update the mfe guide to match the new changes added

@Coly010 Coly010 self-assigned this Mar 23, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 23, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit da5551d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 23, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/5qAtJyw8zQCZTUjN7Y2nNSsFPHZ5
✅ Preview: https://nx-dev-git-fork-coly010-angular-update-mfe-guide-docs-nrwl.vercel.app

leosvelperez
leosvelperez approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 force-pushed the angular/update-mfe-guide-docs branch from ca1022a to da5551d Compare March 23, 2022 11:46
@Coly010 Coly010 merged commit 09ad5ff into nrwl:master Mar 24, 2022
@Coly010 Coly010 deleted the angular/update-mfe-guide-docs branch March 24, 2022 09:28
Coly010 added a commit to Coly010/nx that referenced this pull request Mar 24, 2022
@Coly010
Revert "docs(angular): update the mfe guide (nrwl#9478)"
1dfda78 
This reverts commit 09ad5ff.
Coly010 added a commit that referenced this pull request Mar 24, 2022
@Coly010
Revert "docs(angular): update the mfe guide (#9478)" (#9492)
1903f01 
This reverts commit 09ad5ff.
Coly010 added a commit to Coly010/nx that referenced this pull request Mar 24, 2022
@Coly010
Revert "Revert "docs(angular): update the mfe guide (nrwl#9478)" (nrw…
062a1ad 
…l#9492)"

This reverts commit 1903f01.
Coly010 added a commit to Coly010/nx that referenced this pull request Mar 28, 2022
@Coly010
Revert "Revert "docs(angular): update the mfe guide (nrwl#9478)" (nrw…
2050d65 
…l#9492)"

This reverts commit 1903f01.
Coly010 added a commit to Coly010/nx that referenced this pull request Mar 30, 2022
@Coly010
Revert "Revert "docs(angular): update the mfe guide (nrwl#9478)" (nrw…
77dcfd5 
…l#9492)"

This reverts commit 1903f01.
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@Coly010 @sidmonta
docs(angular): update the mfe guide (nrwl#9478)
a3f39c6
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@Coly010 @sidmonta
Revert "docs(angular): update the mfe guide (nrwl#9478)" (nrwl#9492)
d5a9473 
This reverts commit 09ad5ff.
Coly010 added a commit that referenced this pull request Apr 7, 2022
@Coly010
docs(angular): update mfe guide (#9500)
751e80b 
* Revert "Revert "docs(angular): update the mfe guide (#9478)" (#9492)"

This reverts commit 1903f01.

* docs(angular): fix guide to use mfe.config.js
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leosvelperez leosvelperez leosvelperez approved these changes

Assignees

@Coly010 Coly010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Coly010 @leosvelperez