Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): toggle additional prompts in CNW with a flag #9546

Merged
merged 6 commits into from
Mar 29, 2022
Merged

feat(core): toggle additional prompts in CNW with a flag #9546

merged 6 commits into from
Mar 29, 2022

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Mar 26, 2022 •
edited
Loading

  • Add prompts for defaultBase and packageManager
  • Add new flag, allPrompts, for toggling the above mentioned prompts
  • Switch to yargs for command definition
  • Generate docs
  • Extract shared CLI docs functions

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Mar 26, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 126448e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@meeroslav meeroslav self-assigned this Mar 26, 2022
@vercel
Copy link

vercel bot commented Mar 26, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/FBLEVT2AnYq7mvJ8MxNnMNtxviiv
✅ Preview: https://nx-dev-git-fork-meeroslav-feat-add-advanced-cnw-view-nrwl.vercel.app

@meeroslav meeroslav added the scope: core core nx functionality label Mar 28, 2022
@meeroslav meeroslav marked this pull request as ready for review March 28, 2022 14:24
bcabanes
bcabanes reviewed Mar 28, 2022
View reviewed changes
packages/create-nx-workspace/bin/decorator.ts Outdated
import * as chalk from 'chalk';

export const yargsDecorator = {
'Options:': `${chalk.green('Options')}:`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using an arbitrary colour, what do you think of using chalk.bold() instead? That way we would respect any terminal theme options.

@bcabanes
Copy link
Member

What do you think about mentioning, adding a link to the newly created create-nx-workspace API doc to this page: https://nx.dev/getting-started/nx-setup?

@meeroslav
Copy link
Contributor Author

What do you think about mentioning, adding a link to the newly created create-nx-workspace API doc to this page: https://nx.dev/getting-started/nx-setup?

Let me do it in a separate PR. I have also another change @FrozenPandaz and I discussed today:

  • adding types to CLI options

@FrozenPandaz FrozenPandaz merged commit 9e06020 into nrwl:master Mar 29, 2022
sidmonta pushed a commit to sidmonta/nx that referenced this pull request Apr 2, 2022
@meeroslav @sidmonta
feat(core): toggle additional prompts in CNW with a flag (nrwl#9546)
6f8360a 
* feat(core): toggle additional prompts in CNW with a flag

* feat(repo): handle cli params with yargs

* feat(core): add docs generation

* chore(repo): add colors

* fix(core): migrate to yargs 17.x

* fix(core): update markup generation
@meeroslav meeroslav deleted the feat/add-advanced-cnw-view branch November 8, 2022 15:33
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcabanes bcabanes bcabanes left review comments

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

Assignees

@meeroslav meeroslav

Labels
scope: core core nx functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meeroslav @bcabanes @FrozenPandaz