PERSONA-180 run rate limit when there is a response #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e api with 4XX errors
decarvalhorobinson
changed the title
mburtless
approved these changes
May 20, 2021
mburtless
suggested changes
May 20, 2021
rest/client.go
Outdated
| @@ -164,6 +164,12 @@ func SetDDIAPI() func(*Client) { | |||
| // non-2XX response. | |||
| func (c Client) Do(req *http.Request, v interface{}) (*http.Response, error) { | |||
| resp, err := c.httpClient.Do(req) | |||
|
|
|||
| if resp != nil { | |||
There was a problem hiding this comment.
Can we move this check below the if err != nil beneath this? I don't think there's a reason to eschew Go's convention for error checking immediately after the func call, since HTTP error status code does not result in httpClient.Do returning an err, right?
There was a problem hiding this comment.
If the "doer" doesn't return any errors for the requests that have responses, it makes sense to move it down after the first error checking. I am testing, if everything works well I will make another commit moving it
There was a problem hiding this comment.
I moved since it seems what you said is correct, so it makes senses to keep it after the first error checking
decarvalhorobinson
force-pushed
the
PERSONA-180/check-rate-limit-before-returning
branch
from
8427723
to
571c6b1
Compare
decarvalhorobinson
force-pushed
the
PERSONA-180/check-rate-limit-before-returning
branch
from
571c6b1
to
e610b7b
Compare
decarvalhorobinson
deleted the
PERSONA-180/check-rate-limit-before-returning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error occurs the client will not run the rate limit, which causes too many requests to be fired and then will hit the endpoints rate limit. So to avoid this, the rate limit function will be run when there is a response from the client payload. This was noticed when running terraform provider with invalid fields, which caused 400 errors