Add "WithContext" methods #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this keeps all the exact same functionality of the original methods, but now allows a context to be passed in for better control of the request. this is the preferred way of managing a req, setting it's deadline, adding instrumentation, etc.
jamesgoodhouse
force-pushed
the
add_with_context_methods
branch
from
4d7ddad
to
92b7201
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps all the exact same functionality of the original methods, but now allows a context to be passed in for better control of the request. This is the preferred way of managing a request, setting a deadline, adding instrumentation, etc. Addresses issue #180.