Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#36] TPM Provisioner status output #37

Merged
merged 1 commit into from
Oct 31, 2018
Merged

[#36] TPM Provisioner status output #37

merged 1 commit into from
Oct 31, 2018

Conversation

chubtub
Copy link
Contributor

@chubtub chubtub commented Oct 24, 2018

This change captures the log output from HIRS_Provisioner in the console like so:

TPM 1.2 detected.
--> Configuring provisioner
----> Deleting existing key store
----> Downloading truststore
--> Provisioning
----> Removing old provisioner scripts, if any
----> Provisioning TPM
----> Collecting device information
----> Got endorsement credential from TPM
----> Sending Attestation Identity Credential Request
----> Attestation Identity Provisioning succeeded

Closes #36

apldev3
apldev3 reviewed Oct 24, 2018
View reviewed changes
Copy link
Contributor

@apldev3 apldev3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about this thought.

HIRS_Provisioner/src/main/resources/log4j2.xml Outdated Show resolved Hide resolved
apldev3
apldev3 suggested changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@apldev3 apldev3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shift to System.out.println

apldev3
apldev3 approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@apldev3 apldev3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@apldev3
Copy link
Contributor

apldev3 commented Oct 31, 2018

@iadgovuser26 does this update look fine to you?

iadgovuser26
iadgovuser26 approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@iadgovuser26 iadgovuser26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Works too.

@iadgovuser26 iadgovuser26 merged commit 90d7f40 into master Oct 31, 2018
@apldev3 apldev3 deleted the issue-36 branch November 1, 2018 00:53
cyrus-dev pushed a commit that referenced this pull request Apr 1, 2019
@iadgovuser26
Merge pull request #37 from nsacyber/issue-36
f2db4f4 
[#36] TPM Provisioner status output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apldev3 apldev3 apldev3 approved these changes

@iadgovuser26 iadgovuser26 iadgovuser26 approved these changes

@apldev4 apldev4 Awaiting requested review from apldev4

@apldev1 apldev1 Awaiting requested review from apldev1

@apldev2 apldev2 Awaiting requested review from apldev2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chubtub @apldev3 @iadgovuser26