This repository has been archived by the owner on Mar 22, 2021. It is now read-only.
Unauthorized access on namespaced examples #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI error is not related to this PR, I'll try to fix it during the review. |
|
Closing this since we switched away from Knock to otp-jwt. Thank you!!! 🙇 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples in #126 do not cover unauthorized access to a Knock controller (basically Knock won't protect your endpoints if you follow the current instructions).
I suggest replacing those with the available API methods. Alternatively, I'm open to other suggestions.
I spent some time figuring out why the readme instructions do not work, it would be great if other developers do not hit the same issue.
Thanks in advance for taking a look.