NumericStepper – skjule verdien dersom verdien er null + forbedret UU #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a209223 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
selbekk
commented
May 24, 2023
Comment on lines
+108
to
+109
| aria-live="assertive" | ||
| aria-label={value} |
There was a problem hiding this comment.
Input-felt leser ikke opp innholdet sitt automatisk, selv om man har aria-live på. Derfor må man bruke aria-label i tillegg, så den får med seg at ting endrer seg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bakgrunn
Om man har valgt 0 ting, burde man ikke vise tallet. Og så burde tallet leses opp dersom man endrer verdien med knapper.
Løsning
Implementer dette ved å bruke
visibility, så den fortsetter å ta opp plass.Also, legg til
aria-live="assertive"ogaria-label, slik at skjermlesere leser opp den nye verdien når man trykker på knapper.