Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expandable title prop #786

Merged
merged 1 commit into from
Aug 20, 2023
Merged

fix: Expandable title prop #786

merged 1 commit into from
Aug 20, 2023

Conversation

haakonmt
Copy link
Contributor

Bakgrunn

AccordionProps og AccordionItemProps drar med seg det native HTML-attributtet title, og det blir ikke korrekt overskrevet av title-propen i Spor.

Løsning

Omitter title fra AccordionProps og AccordionItemProps, slik at det er vår title-prop som blir brukt.

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2023

🦋 Changeset detected

Latest commit: 2f31743

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vygruppen/spor-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@selbekk selbekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Takker og bukker!

@selbekk selbekk merged commit 81aed3c into main Aug 20, 2023
1 check passed
@selbekk selbekk deleted the fix-expandable-title branch August 20, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants