Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion design tweaks #794

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Accordion design tweaks #794

merged 4 commits into from
Aug 23, 2023

Conversation

selbekk
Copy link
Contributor

@selbekk selbekk commented Aug 23, 2023

Bakgrunn

Det var endel småfeil med implementasjonen til Accordion.

Løsning

Endre endel småting med hvordan accordions ser ut, inkludert

  • Mindre avstand mellom ikon og tittel
  • Fet tekst i tittel
  • Mindre bottom padding i accordion panelet
  • Bruke lang-form padding-props
  • Fjerne outline på active-staten til list-accordions.

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

🦋 Changeset detected

Latest commit: 276c86f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vygruppen/spor-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ref={ref}
defaultIndex={defaultIndex as number[] | undefined}
>
<Stack spacing={spacing}>{children}</Stack>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eneste endringen er å legge til en Stack her.

Comment on lines +89 to +92
boxShadow: getBoxShadowString({
baseShadow: "sm",
borderColor: "silver",
}),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Endre skyggen til card accordions til å se ut som cards.

},
panel: {
px: 2,
fontSize: "desktop.xs",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Her legger jeg også opp til en default tekststørrelse for innhold.

@selbekk selbekk merged commit 81c256b into main Aug 23, 2023
1 check passed
@selbekk selbekk deleted the accordion-design-tweaks branch August 23, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant