Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more space for larger numbers in Numeric Stepper #798

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

AnamaP
Copy link
Contributor

@AnamaP AnamaP commented Aug 24, 2023

Background

When using the Numeric Stepper, having the withInput prop set to false, the space becomes too small when the number becomes greater than 19. This causes the numbers to overlap each other.

Solution

For now, we just increase the width one notch. Screenshot from Playground:

Screenshot 2023-08-24 at 13 15 50

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023

⚠️ No Changeset found

Latest commit: dc4bdca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AnamaP AnamaP merged commit a8bc886 into main Aug 25, 2023
1 check passed
@AnamaP AnamaP deleted the more-spacing-numeric-stepper branch August 25, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants