Override minimum left padding in ComboBox and InfoSelect popovers #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heisand
requested review from
idagyl,
a team,
selbekk,
emildohlenhansen,
cecilmkl and
AnamaP
and removed request for
a team
🦋 Changeset detectedLatest commit: 29e323b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
heisand
changed the title
heisand
changed the title
emildohlenhansen
approved these changes
Sep 1, 2023
AnamaP
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
A negative margin was added to the popover due to that the ComboBox popover was displaced some pixels to the right in the app it was used after removing the overlay. The popover will in fact always be displaced to the right relative to the input field when there is less than 12 px padding to the left in the container. This is because the default minimum container padding is 12 px.
By adding a negative margin, it worked against its purpose for InfoSelect and ComboBox when there is enough left padding, causing the popover to be displaced the opposite way.
Solution
We can override the minimum padding by passing
containerPadding: 0tousePopover.