Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make icon and color boxes light grey #839

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

selbekk
Copy link
Contributor

@selbekk selbekk commented Sep 8, 2023

Background

After removing the outline from cards, white cards look invisible on white backgrounds. We've been using white cards on white backgrounds a few places in our docs site, and will have to change those usecases.

Solution

Change to using the grey version of cards for icons and color tokens.

Icons:

image

Colors

image

@selbekk selbekk requested a review from perweum September 8, 2023 10:23
@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2023

⚠️ No Changeset found

Latest commit: 24a23a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@perweum perweum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tommel opp

@selbekk selbekk merged commit c2b8e0e into main Sep 8, 2023
1 check passed
@selbekk selbekk deleted the make-boxes-light-grey branch September 8, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants