-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: read multiple Grids in XDMF #610
Conversation
This includes #609. |
Thus far, this does read multiple Grids well enough to read the MWE; but perhaps this should go further and:
The exact desired behaviour does depend on bit on the interpretation of tagged subsets of elements in meshio #290. |
Given the current code Line 251 in 23fa4ef
plus the new code in #610 to read multiple Grids, subsequent grids with the same cell_data[xdmf_to_meshio_type[cell_type]]["gmsh:physical"] or something like MED for which I see Lines 105 to 114 in 23fa4ef
though I'm not familiar with the MED format so don't know what that attribute would usually be expected to contain. …Ah, I've just noticed that |
This now works again, following the switch from It remains to also write multiple grids, thereby:
|
The smaller a PR, the better; we can do multiple grids later. Best bring this one here into a reviewable state. |
Yes, right, sorry; I'll split this up. |
This is for #568.