Update _legend.py #581
Open
Update _legend.py #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible typo: `_ncol` instead of `n_cols`.
With `_ncol` calling `tikzplotlib.save()` on a plot containing legends results in the error:
```
Traceback (most recent call last):
File "/home/marvin/phd_scripts/2023_04_14 picoscope/analyzepicoscope_class.py", line 36, in <module>
tikzplotlib.save("picoscope.tikz")
File "/home/marvin/.local/lib/python3.10/site-packages/tikzplotlib/_save.py", line 262, in save
code = get_tikz_code(*args, filepath=filepath, **kwargs)
File "/home/marvin/.local/lib/python3.10/site-packages/tikzplotlib/_save.py", line 213, in get_tikz_code
data, content = _recurse(data, figure)
File "/home/marvin/.local/lib/python3.10/site-packages/tikzplotlib/_save.py", line 352, in _recurse
data, children_content = _recurse(data, child)
File "/home/marvin/.local/lib/python3.10/site-packages/tikzplotlib/_save.py", line 380, in _recurse
data = _legend.draw_legend(data, child)
File "/home/marvin/.local/lib/python3.10/site-packages/tikzplotlib/_legend.py", line 81, in draw_legend
if obj._ncol != 1:
AttributeError: 'Legend' object has no attribute '_ncol'. Did you mean: '_ncols'?
```
|
This duplicates (at least) #574, #565, #558 and #579 and just has not been merged yet, see #574 (comment) as well. This is no typo, but a change from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible typo:
_ncolinstead ofn_cols.With
_ncolcallingtikzplotlib.save()on a plot containing legends results in the error: