Feature/task 6 #28
Closed
Feature/task 6 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuaniSilva
reviewed
Jan 19, 2023
|
Ahí eliminé el archivo pnpm-lock.yaml |
JuaniSilva
approved these changes
Jan 20, 2023
nsdonato
requested changes
Jan 23, 2023
Closed
3 tasks
nsdonato
requested changes
Jan 23, 2023
|
Borre el package.json viendo el problema de las dependencias sin querer y tuve que hacer un git force 😨 (seguro hay una mejor forma). De todos modos tengo problemas con el package.json y las dependencias porque instale @testing-library/react-hooks para testear el hook y había un problema con las peer dependencies. |
| @@ -0,0 +1,10 @@ | |||
| import Darkmode from "."; | |||
There was a problem hiding this comment.
mover este test a la siguiente ubicacion src/tests/DarkMode/DarkMode.test.tsx
phreakphreak
requested changes
Jan 24, 2023
nsdonato
approved these changes
Jan 25, 2023
|
@techwithmat no te hagas problema, yo resolví el problema de las dependencias, ya esta este pr en main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧾 Invoices App Pull Request
Descripcion ✏️
Cambios visuales 🎨
N/A
Como testear? 🐛
Ejecutando los tests con
npm run test😅