Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gocode panic on windows with import "path/filepath" #37

Closed
vanackere opened this issue May 20, 2011 · 4 comments
Closed

gocode panic on windows with import "path/filepath" #37

vanackere opened this issue May 20, 2011 · 4 comments

Comments

@vanackere
Copy link
Contributor

Hi, gocode panic on windows on any unit that tries to import path/filepath :

fail.go:
package main
import "path/filepath"

gocode -in fail.go autocomplete 1

@nsf
Copy link
Owner

nsf commented May 20, 2011

Are you sure you're using the latest version of the gocode and the Go compiler? Check it. I won't fix this bug, no windows on my machine, sorry.

If anyone can fix it or at least confirm it - do it.

@vanackere
Copy link
Contributor Author

Yes, latest hg / git of go / gocode.
I'll investigate and either provide more details or propose a fix.

@vanackere
Copy link
Contributor Author

Got it.

The bug is triggered by the following declaration in windows filepath.a :

const "".SeparatorString string = "\\"

... this breaks the parsing in PackageFileCache.expandPackages

Almost trivial patch attached, please apply :-)
It looks like there are other bugs on windows when not using mingw to
run gocode. I'll try to fix them separately...

Best regards,

Vincent

On Fri, May 20, 2011 at 9:01 PM, nsf
reply@reply.github.com
wrote:

Are you sure you're using the latest version of the gocode and the Go compiler? Check it. I won't fix this bug, no windows on my machine, sorry.

If anyone can fix it or at least confirm it - do it.

Reply to this email directly or view it on GitHub:
#37 (comment)

@nsf
Copy link
Owner

nsf commented May 23, 2011

Committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants