Skip to content
This repository has been archived by the owner on Dec 6, 2019. It is now read-only.

Repair dropdown selection & FSFK Map Additions #115

Merged
merged 5 commits into from Sep 30, 2013
Merged

Conversation

DavidJClark
Copy link

Repair dropdown selection in admin settings template for default user field.

FSFK map additions.

Signed-off-by: DavidJClark david@noticeabledesigns.com

DavidJClark added 3 commits September 25, 2013 10:57
… field.

Signed-off-by: DavidJClark <david@noticeabledesigns.com>
Signed-off-by: DavidJClark <david@noticeabledesigns.com>
Signed-off-by: DavidJClark <david@noticeabledesigns.com>
@Oxymoron290
Copy link

change $sel = ($current->value == $group->groupid ? 'selected="selected"' : '');
to $sel = ($current->value == $group->groupid ? 'selected' : '');
as this attribute doesn't hold a value, it's simply set when the attribute key exists. However most browsers do allow for a value to this attribute and in that case the value would be boolean, either true or false. In no case is the value "selected" valid for the selected attribute.

sauce: http://stackoverflow.com/questions/1033944/what-values-can-appear-in-the-selected-attribute-of-the-option-tag

also, good catch.

@DavidJClark
Copy link
Author

@Oxymoron290 - That part does not matter to me, I wrote it out of habit. The change that was made to make the drop down function correctly is:

$current
to
$current->value

DavidJClark added 2 commits September 25, 2013 21:50
Changed value for group permissions for default admin group to allow use of FULL_ADMIN setting.

Signed-off-by: DavidJClark <david@noticeabledesigns.com>
nabeelio added a commit that referenced this pull request Sep 30, 2013
Repair dropdown selection & FSFK Map Additions
@nabeelio nabeelio merged commit 2c78147 into phpvms:dev Sep 30, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants