Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The readBed function does not transform from 0-based to 1-based coordinates #22

Closed
deyanyosifov opened this issue Aug 31, 2017 · 4 comments

Comments

@deyanyosifov
Copy link

Hello, I think I found a bug in the readBed function. I used it to read a .bed file with differentially methylated CpG sites. LOLA complained that the ranges are not disjoined. This was strange as each CpG range is 2 nucleotides long and they can't possibly be overlapping. I inspected the GRanges object and saw that the ranges are 3 nucleotides long. There were a few instances in which there were neighbouring CpGs and their ranges overlapped, e.g. 34567-34569 and 34569-34571, matching the ranges in the .bed file. As GRanges coordinates are 1-based, the coordinates should have been transformed to 34568-34569 and 34570-34571. I found a workaround for my problem by creating and using a non-standard .bed file with 1-based coordinates but I think the readBed function should be made to take into account the difference between coordinate systems and transform coordinates correctly.

@deyanyosifov
Copy link
Author

I've just seen that this issue has been raised before and has been marked as closed. Maybe I'm just not using the latest version? I use LOLA_1.6.0 from Bioconductor.

@nsheff
Copy link
Owner

nsheff commented Aug 31, 2017

Yeah, it's corrected in version 1.7.1, which is currently in the development bioconductor branch:

https://bioconductor.org/packages/devel/bioc/html/LOLA.html

https://github.com/nsheff/LOLA/blob/master/NEWS

Sorry for the inconvenience.

@nsheff
Copy link
Owner

nsheff commented Aug 31, 2017

( you could also just install the version on github if you don't want to wait for bioc dev)

@deyanyosifov
Copy link
Author

Thank you!

@nsheff nsheff closed this as completed Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants