Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom SMTP hosts #10

Closed
nshki opened this issue Jun 11, 2024 · 0 comments · Fixed by #13
Closed

Support custom SMTP hosts #10

nshki opened this issue Jun 11, 2024 · 0 comments · Fixed by #13
Labels
enhancement New feature or request

Comments

@nshki
Copy link
Owner

nshki commented Jun 11, 2024

Currently, only Gmail, Outlook, Proton Mail, and Fastmail are supported for SMTP. We should support custom SMTP domains and ports to allow for self-hosters to be able to use the service as well.
@nshki nshki added the enhancement New feature or request label Jun 11, 2024
@nshki nshki mentioned this issue Jun 16, 2024
Merged
@nshki nshki closed this as completed in #13 Jun 16, 2024
@nshki nshki closed this as completed in 9b9334e Jun 16, 2024
@nshki nshki mentioned this issue Jun 17, 2024
Merged
nshki added a commit that referenced this issue Jun 17, 2024
@nshki
fix: broken sends (#15)
4436694 
# Overview

Follow-up from #10. The methods that return the SMTP host and port were
written in a way that would return empty strings for non-custom SMTP
configs, which was not right. This corrects that mistake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support custom SMTP hosts nshki/naisho
1 participant
@nshki