Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required and help #4

Merged
merged 2 commits into from
Nov 7, 2016
Merged

Fix required and help #4

merged 2 commits into from
Nov 7, 2016

Conversation

nsomar
Copy link
Owner

@nsomar nsomar commented Nov 5, 2016

Fix bug that happens if we request help and we have a required flag. The required flag would eat the help flag

@nsomar nsomar changed the base branch from master to adding-remove-method November 5, 2016 18:08
@codecov-io
Copy link

codecov-io commented Nov 5, 2016

Current coverage is 94.80% (diff: 88.23%)

Merging #4 into adding-remove-method will increase coverage by 0.15%

@@           adding-remove-method         #4   diff @@
======================================================
  Files                        22         22          
  Lines                      1551       1560     +9   
  Methods                       0          0          
  Messages                      0          0          
  Branches                      0          0          
======================================================
+ Hits                       1468       1479    +11   
+ Misses                       83         81     -2   
  Partials                      0          0          

Powered by Codecov. Last update 285b72b...9976752

@nsomar nsomar changed the base branch from adding-remove-method to master November 7, 2016 19:36
@nsomar nsomar merged commit 9eafa23 into master Nov 7, 2016
@nsomar nsomar deleted the fix-required-and-help branch November 7, 2016 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants