workflows: fix upload to NeoFS #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
force-pushed
the
fix-upload
branch
4 times, most recently
from
dcefec5
to
ae02c03
Compare
roman-khimov
added a commit
to nspcc-dev/gh-push-to-neofs
that referenced
this pull request
May 9, 2024
Website built into "site-dir" is the root of container, so FilePath there should be "index.html" and not "site-dir/index.html". Related to nspcc-dev/fs-neo-org#53 Signed-off-by: Roman Khimov <roman@nspcc.ru>
gh-push-to-neofs doesn't strip PATH_TO_FILES_DIR from FilePath which leads to uploads using attributes like --attributes FilePath=fs.neo.org/images/icons/icon5.svg,ContentType=image/svg+xml while in fact we need --attributes FilePath=images/icons/icon5.svg,ContentType=image/svg+xml for the site to work properly. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
to nspcc-dev/gh-push-to-neofs
that referenced
this pull request
May 9, 2024
Website built into "site-dir" is the root of container, so FilePath there should be "index.html" and not "site-dir/index.html". Related to nspcc-dev/fs-neo-org#53 Signed-off-by: Roman Khimov <roman@nspcc.ru>
|
Depends on nspcc-dev/gh-push-to-neofs#21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-push-to-neofs doesn't strip PATH_TO_FILES_DIR from FilePath which leads to uploads using attributes like
--attributes FilePath=fs.neo.org/images/icons/icon5.svg,ContentType=image/svg+xml
while in fact we need
--attributes FilePath=images/icons/icon5.svg,ContentType=image/svg+xml
for the site to work properly.