Fix dotnet compatibility #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes encoding follow .NET JSON/UTF8 libraries as much as possible,
tested with
using System;
using System.IO;
using System.Text.Json;
public class Program
{
public static void Main()
{
string controls = "\x00\x01";
MemoryStream ms = new MemoryStream();
Utf8JsonWriter writer = new Utf8JsonWriter(ms, new JsonWriterOptions
{
SkipValidation = true,
});
writer.WriteStringValue(controls);
writer.Flush();
byte[] res = ms.ToArray();
string result = System.Text.Encoding.UTF8.GetString(res);
Console.WriteLine(result);
}
}
which is similar to what Neo does. Can't comment on differences much because
that's just the way .NET is, it doesn't use \ufffd, it escapes some controls in
a different way, it just does what it wants and we have to follow here to be
compatible.
Notice that C# `\x` escaping differs from Go significantly if you want to play
with it (it's `\xH[H][H][H]` instead of `\xHH`). It also interprets bytes a bit
differently.
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Seems like they're so old they can't be executed. Drop useless actions at the same time. Signed-off-by: Roman Khimov <roman@nspcc.ru>
AliceInHunterland
approved these changes
Feb 29, 2024
AnnaShaleva
approved these changes
Feb 29, 2024
| "fmt" | ||
| "github.com/virtuald/go-ordered-json" |
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Feb 29, 2024
Fetch C# node compatibility fixes for the rest of corner cases. Ref. nspcc-dev/go-ordered-json#11. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As much as it can be fixed at the moment.