Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple workers for rate bench mode #170

Closed
AnnaShaleva opened this issue May 13, 2024 · 0 comments · Fixed by #172
Closed

Support multiple workers for rate bench mode #170

AnnaShaleva opened this issue May 13, 2024 · 0 comments · Fixed by #172
Assignees
@AliceInHunterland
Labels
feature Completely new functionality I2 Regular impact S2 Regular significance U2 Seriously planned

Comments

@AnnaShaleva
Copy link
Member

AnnaShaleva commented May 13, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Currently rate bench mode produces single-threaded network load:

neo-bench/cmd/bench/main.go

Lines 52 to 53 in 7ee7f71

case internal.ModeRate:
workers = 1

It's not enough for real networks (ref. #160), we're facing with the issue when loader can't produce the necessary load level.

Describe the solution you'd like

We need to run multiple workers for the rate mode and share the load between them. The number of workers may be hard-coded for the first time. A tricky part is to properly synchronize these workers to produce the desired RPS, this should be handled with care.
@AnnaShaleva AnnaShaleva added U2 Seriously planned S2 Regular significance I2 Regular impact feature Completely new functionality labels May 13, 2024
@AnnaShaleva AnnaShaleva mentioned this issue May 13, 2024
Open
AliceInHunterland added a commit that referenced this issue May 14, 2024
@AliceInHunterland
bench: add workers into rate mode
f02c77d 
We need to run multiple workers for the rate mode and share the load
between them.

Close #170

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland AliceInHunterland mentioned this issue May 14, 2024
Merged
AliceInHunterland added a commit that referenced this issue May 14, 2024
@AliceInHunterland
bench: add workers into rate mode
2231c0e 
We need to run multiple workers for the rate mode and share the load
between them.

Close #170

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue May 15, 2024
@AliceInHunterland
bench: add workers into rate mode
19b9bde 
We need to run multiple workers for the rate mode and share the load
between them.

Close #170

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue May 15, 2024
@AliceInHunterland
bench: add workers into rate mode
0c57147 
We need to run multiple workers for the rate mode and share the load
between them.

Close #170

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue May 16, 2024
@AliceInHunterland
bench: add workers into rate mode
0581599 
We need to run multiple workers for the rate mode and share the load
between them.

Close #170

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue May 16, 2024
@AliceInHunterland
bench: add workers into rate mode
7b43f94 
We need to run multiple workers for the rate mode and share the load
between them.

Close #170

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue May 16, 2024
@AliceInHunterland
bench: add workers into rate mode
158c15c 
We need to run multiple workers for the rate mode and share the load
between them.

Close #170

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue May 16, 2024
@AliceInHunterland
bench: add workers into rate mode
8cddeec 
We need to run multiple workers for the rate mode and share the load
between them.

Close #170

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue May 16, 2024
@AliceInHunterland
bench: add workers into rate mode
eace8ed 
We need to run multiple workers for the rate mode and share the load
between them.

Close #170

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue May 16, 2024
@AliceInHunterland
bench: add workers into rate mode
763e739 
We need to run multiple workers for the rate mode and share the load
between them.

Close #170

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue May 21, 2024
@AliceInHunterland
bench: add workers into rate mode
5858d3f 
We need to run multiple workers for the rate mode and share the load
between them.

Close #170

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue May 22, 2024
@AliceInHunterland
bench: add workers into rate mode
4aaca31 
We need to run multiple workers for the rate mode and share the load
between them.

Close #170

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliceInHunterland AliceInHunterland

Labels
feature Completely new functionality I2 Regular impact S2 Regular significance U2 Seriously planned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bench: add workers into rate mode nspcc-dev/neo-bench
2 participants
@AnnaShaleva @AliceInHunterland