Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix failing Secp256r1 test #1232

Merged
merged 3 commits into from
Jul 26, 2020
Merged

crypto: fix failing Secp256r1 test #1232

merged 3 commits into from
Jul 26, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jul 25, 2020 •
edited
Loading

  1. Pad R and S when computing signature in Secp256k1 test.
  2. Ensure public key is invalid in interop test.

Fix #1223.

@codecov
Copy link

codecov bot commented Jul 25, 2020 •
edited
Loading

Codecov Report

Merging #1232 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1232   +/-   ##
=======================================
  Coverage   66.80%   66.80%           
=======================================
  Files         199      199           
  Lines       17000    17002    +2     
=======================================
+ Hits        11357    11359    +2     
  Misses       5028     5028           
  Partials      615      615
Impacted Files Coverage Δ
pkg/crypto/keys/private_key.go 84.70% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45c160...83e53fa. Read the comment docs.

@fyrchik
keys: fix failing Secp256k1 test
76fdbea 
Pad R and S when computing signature.
Fix #1223.
@fyrchik
core/test: ensure public key is invalid in test
83e53fa 
When providing public key as a subslice, it still can be
decoded as a valid key, thus interop will not return an error
but rather push `false` on stack. This test is about providing
invalid key, so ensure this via setting invalid prefix.
@fyrchik
core/interop: increase coverate for crypto interops
8931c9a
@roman-khimov roman-khimov merged commit 5983e6b into master Jul 26, 2020
@roman-khimov roman-khimov deleted the fix/verifytest branch July 26, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@AnnaShaleva AnnaShaleva Awaiting requested review from AnnaShaleva AnnaShaleva is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix failing test on go1.13
2 participants
@fyrchik @roman-khimov