core, consensus: add maxBlockSystemFee to native Policy #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1254 +/- ##
==========================================
- Coverage 67.52% 67.47% -0.05%
==========================================
Files 214 214
Lines 18049 18124 +75
==========================================
+ Hits 12187 12229 +42
- Misses 5218 5245 +27
- Partials 644 650 +6
Continue to review full report at Codecov.
|
roman-khimov
approved these changes
Aug 3, 2020
fyrchik
approved these changes
Aug 4, 2020
We should also take into account maxBlockSize in (bc *Blockchain).ApplyPolicyToTxSet
To follow C# implementation we should also check proposed block on policy matching.
AnnaShaleva
force-pushed
the
native/policy/maxblocksystemfee
branch
from
f5ee8e3
to
db65ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1195