Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: use lowercase JSON field names for StateHeight #1274

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

roman-khimov
Copy link
Member

Follow neo-project/neo#1808. Note that this is an incompatible change, but
this feature is still considered to be experimental upstream.

Follow neo-project/neo#1808. Note that this is an incompatible change, but
this feature is still considered to be experimental upstream.
@roman-khimov roman-khimov added the rpc RPC server and client label Aug 5, 2020
@roman-khimov roman-khimov added this to the v0.77.0 milestone Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #1274 into master-2.x will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           master-2.x    #1274      +/-   ##
==============================================
- Coverage       67.93%   67.92%   -0.02%     
==============================================
  Files             159      159              
  Lines           15645    15645              
==============================================
- Hits            10629    10627       -2     
- Misses           4486     4488       +2     
  Partials          530      530              
Impacted Files Coverage Δ
pkg/rpc/response/result/mpt.go 73.58% <ø> (ø)
pkg/rpc/client/wsclient.go 84.35% <0.00%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a702423...ab5eff6. Read the comment docs.

@roman-khimov roman-khimov marked this pull request as draft August 5, 2020 15:22
@roman-khimov roman-khimov marked this pull request as ready for review August 7, 2020 07:18
@roman-khimov roman-khimov merged commit db98f8f into master-2.x Aug 7, 2020
@roman-khimov roman-khimov deleted the lowercase-json-field-names-for-stateroot branch August 7, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants